Add new flag --auto-select: when there is only one entry left, automaticallty select it #357
Conversation
|
I think there's confusion what accept-single is supposed to do. The accept-single is supposed to return immediately if there's only one item in the list, this seems to change the behavior that accept-single returns immediately if filter out the list enough that there remains only one item. |
|
I thought accept single was the pendant to dmenu's "instant" patch or
rofi's auto select. If this is not the case, would you consider adding such
an option?
…On Wed, Sep 27, 2023, 02:53 Jari Vetoniemi ***@***.***> wrote:
I think there's confusion what accept-single is supposed to do. The
accept-single is supposed to return immediately if there's only one item in
the list, this seems to change the behavior that accept-single returns
immediately if filter out the list enough that there remains only one item.
—
Reply to this email directly, view it on GitHub
<#357 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAT3NGQUULO5LXXZJMH2C3X4N2HJANCNFSM6AAAAAA5HR2TYA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yes that kind of behavior would be a new option |
|
Would you accept a patch which implements that functionality under the flag "--accept-single", mirroring rofi's own option? |
|
That would break the current expected behavior of --accept-single, patch with different flag name is okay. |
|
Optional argument for --accept-single could work too as well I guess, something like "always" |
…ect flag: when there is only one option left during selection it is automatically selected and the menu exits.
gesellkammer
changed the title
|
Reverted the behaviour of --accept-single, added a new flag --auto-select |
|
Can you also document the flag in the man page, looks good otherwise |
|
Thanks |
|
Looks like we hit string length limit:
|
|
Thanks |
This PR fixes --accept-single, see #335