fix: wayland mmap failed on Sway 1.8.1 #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sway 1.8.1 does not trigger some event as surface.enter before we are asked to render the first frame. This cause this first frame to be rendered with wrong attributes. This is solved with Sway master, precisely with commit: > 7d2e4a51063ac90f950cb44f141ab391cbcaff5f > > layer-shell: enter output before surface is mapped > > This sends fractional-scale-v1 events before the first configure > event. That way clients have all of the metadata they need to render > the first frame. To ensure we don't fails rendering the first frame, even if the compositor does not provide metadata in a correct order, we initialize the window structure with default values.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sway 1.8.1 does not trigger some event as surface.enter before we are asked to render the first frame. This cause this first frame to be rendered with wrong attributes. (but that is better than crashing)
This is solved with Sway master, precisely with commit:
To ensure we don't fails rendering the first frame, even if the compositor does not provide metadata in a correct order, we initialize the window structure with default values.