wayland: ensure bemenu is shown on top of fullscreen windows #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, wayland compositors that render fullscreen windows between the top and overlay layers would show bemenu behind an active fullscreen window. For other compositors the z-rendering order was undefined. This change ensures that bemenu will always be on top of other usual windows (including fullscreen ones). Fixes Cloudef#81
|
There used to be security issue related to this in swaylock but I guess it's now ok? |
Indeed, the current locking protocol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, wayland compositors that render fullscreen windows between the top and overlay layers would show bemenu behind an active fullscreen window. For other compositors the z-rendering order was undefined.
This change ensures that bemenu will always be on top of other usual windows (including fullscreen ones).
Fixes