Move SIGCHLD handler #391
Merged
Move SIGCHLD handler #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIG_DFL on SIGCHLD prevents proper functioning of pclose, which the new version of the pasting functionality requires. Closes Cloudef#385 Ref: https://stackoverflow.com/questions/54189212/popen-returns-1-unexpectedly
|
Force pushed to clean up the commit history. Please let me know if this is the right approach, thanks! |
|
Perhaps this code should be moved to the launch function instead of removed |
|
I have moved it, thanks for the suggestion! |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIG_DFL on SIGCHLD prevents proper functioning of pclose, which the new version of the pasting functionality requires.
Closes #385
Ref: https://stackoverflow.com/questions/54189212/popen-returns-1-unexpectedly