Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sys/sysmacros.h for major/minor(3) (Linux) #224

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

Hummer12007
Copy link
Contributor

sys/sysmacros.h implicit inclusion is being deprecated (even with _DEFAULT_SOURCE), so it would cause build breakage on future updates.

See https://bugs.gentoo.org/show_bug.cgi?id=604608 and https://sourceware.org/ml/libc-alpha/2015-11/msg00253.html (also mentioned in glibc news)

@Cloudef
Copy link
Owner

Cloudef commented Jan 13, 2017

Do you know if this breaks compile anywhere?

@Hummer12007
Copy link
Contributor Author

Hummer12007 commented Jan 13, 2017

Well, it (the issue) seems to break the build in gentoo with glibc-2.24 (which is not even keyworded yet), as they decided to patch the implicit include out (again). Same thing happened with 2.23 before (but they have decided to revert it before stabilizing). Who knows what'll happen this time...
At the very least, it is compatible with glibc, musl, and uclibc(-ng).

@Cloudef
Copy link
Owner

Cloudef commented Jan 13, 2017

Lets merge this and think about it if there are complaints.

@Cloudef Cloudef merged commit 6606ae3 into Cloudef:master Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants