-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small changes to make working with Xwayland easyier #255
Conversation
Why are the wlc_x11_ functions needed for public? |
They are not exactly needed, but it's something that's nice to have. It allows to implement "Kill window" option in window menu without creating separate connection to X server. But if it means problem, I can create PR without them. |
why not have them public though? There is nothing wrong with having as detailed public api as possible, for having options ready for people using wlc? Surely that is not a bad thing... if cluttering is a point, just move them to separate api header? |
But if wlc always does this internally when you close a If it's not necessary, I don't see why it should be made public. |
@Cloudef sorry to bother you, but I really would like your option on this. Does it looks at least theoretically mergeable? It looks like I'll have to do more crazy stuff with X11 windows (for example, I'm looking at enabling borders on menus right now) and I'm not sure in which direction should I go. Would it be better to add even more methods to wlc, or scrap even those in this PR and expose XIDs and display connection, so library user can do whatever he wants without help of wlc? |
Preferably, you would not need to do anything x11 related. But if it's really needed just expose the display and xids in wlc-xwayland.h or something. |
The WLC_BIT_BORDERLESS is okay. |
Will do, thanks :)
I'll create another PR just with that for time being. |
In my long running attempt to create more traditional WM based on WLC, I found two things to really hard to do outside of wlc:
WLC_BIT_X11
andWLC_BIT_BORDERLESS
view types to help deciding which is which without doing complicated stuff to determine something that WLC already knows.