Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xwayland selection fix #271

Merged
merged 2 commits into from
Jul 1, 2017
Merged

Xwayland selection fix #271

merged 2 commits into from
Jul 1, 2017

Conversation

nyorain
Copy link
Contributor

@nyorain nyorain commented Jul 1, 2017

This fixes another problem i ran into when debugging images in the clipboard (would really like to finish this feature...).
This patch fixes supported for general mime types; images on the clipboard will work now (works with gnomes epiphany browser and gimp as you described). It does still not work for qutebrowser but this is pretty sure a bug in qt/qutebrowser. It does not work in gnome either, the problem is that qutebrowser does only offer the x-qt-image mime type under wayland which is not supported by gimp (it does not offer the image/{png,jpg,..} mime types as it does under x11).
Not sure if this is a known bug, i personlly don't use qutebrowser but it might be worth a bug report after some research.
Try it out by e.g. logging the supported types received in the compositor directly in data.c, qutebrowser will only offer the (rather useless) x-qt-image mime type for its image data source.
If you have any other ideas for testing this, let me know (was not yet able to get another browser to work on wayland).

@ddevault ddevault merged commit 2eee70c into Cloudef:master Jul 1, 2017
@ddevault
Copy link
Collaborator

ddevault commented Jul 1, 2017

Regarding qutebrowser it probably makes sense to send a patch to Qt to use a more standard format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants