Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify focused client on changed selection #272

Merged
merged 2 commits into from
Jul 1, 2017
Merged

Notify focused client on changed selection #272

merged 2 commits into from
Jul 1, 2017

Conversation

nyorain
Copy link
Contributor

@nyorain nyorain commented Jul 1, 2017

This fixes a data.c bug. Currently, it does not send notifications to the focused client when a selection changes which results in a segmentation fault if the clients tries then to receive from the (no longer valid) data offer. Usually clients don't use the wayland protocol when they want to access their own data source but manage it internally which is why this did not introduce any real problems until now, but would e.g. when implementing swaywm/sway#926 (since then the source is changed without that the client can know it).

@ddevault
Copy link
Collaborator

ddevault commented Jul 1, 2017

This looks fine, but I'm not convinced it'll solve swaywm/sway#926. CLI clients (i.e. clients that don't open a window) aren't going to get focus.

@nyorain
Copy link
Contributor Author

nyorain commented Jul 1, 2017

I fixed the sway issue with a new ipc message (currently preparing the pr).

@ddevault ddevault merged commit 6d28b20 into Cloudef:master Jul 1, 2017
@ddevault
Copy link
Collaborator

ddevault commented Jul 1, 2017

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants