Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic to download the file in conversation from mobile #15

Closed
sojharo opened this issue Feb 22, 2017 · 16 comments
Closed

Logic to download the file in conversation from mobile #15

sojharo opened this issue Feb 22, 2017 · 16 comments

Comments

@sojharo
Copy link
Contributor

sojharo commented Feb 22, 2017

Our files would not be downloaded on initial loading to reduce connection making time. So we would write the logic to download the file from mobile when user wants to download.

@sojharo
Copy link
Contributor Author

sojharo commented Apr 26, 2017

I have worked on it. It is under construction. I am able to get the bits of file coming from mobile. But they aren't converting to file when I merge them. I am looking more into this issue.

@jekram
Copy link
Contributor

jekram commented Apr 26, 2017

Thanks for the update

@sojharo
Copy link
Contributor Author

sojharo commented May 3, 2017

I worked on this yesterday I am still having the problems of rendering the downloaded image from mobile on desktop.

@jekram
Copy link
Contributor

jekram commented May 3, 2017

@sojharo Please see the dependency for iOS

@sojharo
Copy link
Contributor Author

sojharo commented May 3, 2017

Yes Sir working on this task.

@sojharo
Copy link
Contributor Author

sojharo commented May 4, 2017

Yesterday, I read few articles on handling binary data on reactjs and html. From learning and demo of article, I found that we need to use canvas in order to render the incoming image attachment. However, different html elements would be used for different type of files on desktop application. We need to break this task into following subtasks as they all will be handled separately.

  1. UI and logic to handle Image attachment
  2. UI and logic to handle audio attachment
  3. UI and logic to handle video attachment
  4. UI and logic to handle document attachment

I have tried the logic of canvas and this work is under construction.

@jekram
Copy link
Contributor

jekram commented May 4, 2017

How we were handling this before?

@sojharo
Copy link
Contributor Author

sojharo commented May 4, 2017

We were handling in the conference where we used this to do screen sharing coming from android. However, it was separate in logic and did use webrtc data channel and continuously rendered the image. We used angularjs in our conference and in desktop we are using reactjs.

However, the other type of attachments are not done anywhere before. This is our first time that we are moving files using socket.io from mobile to desktop.

@jekram
Copy link
Contributor

jekram commented May 5, 2017

I was referring to how this was done with Android Clint to Desktop App?

@sojharo
Copy link
Contributor Author

sojharo commented May 5, 2017

Yes, this is part of same task. On Android task, I written the code to send the bits of file when desktop asks for it. In this task, I am merging those bits on desktop side to show them as complete file here.

@jekram
Copy link
Contributor

jekram commented May 5, 2017

I am.assuming that Android task is complete. This is a better way of doing same thing? Or how Android did iOS cannot do it? I am not clear on the objective.

@sojharo
Copy link
Contributor Author

sojharo commented May 5, 2017

Yes, the task in android was to send the attachment file to the desktop application in form of bytes using socket.io. Now in this task of desktop application, we need to merge these bytes into one file and use that file. If that is image, then show it as image, if that is audio or video, then we should make it playable,

@jekram
Copy link
Contributor

jekram commented May 5, 2017

Ok. Thanks

@sojharo
Copy link
Contributor Author

sojharo commented May 8, 2017

I worked on this task and I am now able to receive the image attachment from mobile and merge it correctly. I was able to save it to desktop computer and view it. Futher in this task, I would now show the image on canvas as it is merged correctly now.

However, it would help if I open separate tasks for other types of attachments as discussed in #15 (comment)

@jekram
Copy link
Contributor

jekram commented May 8, 2017

Go ahead.

@sojharo
Copy link
Contributor Author

sojharo commented May 11, 2017

I have completed the work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants