Broadcast Test Button not working

[Muzamilbukhari]

After setting up the new broadcast, just before sending it, there is a button to Test it, which is not working.

[jekram]

@sojharo @AnishaChhatwani

Did @AnishaChhatwani not just fixed this issue?

[AnishaChhatwani]

@jekram No Sir. I had worked on template broadcast. Not the test broadcast

[jekram]

@saniasiddiqui You worked on this issue and closed it. Why are we having these issues again? or this is a case that code is not in production?

@sojharo

[jekram]

#4334

[jekram]

Please do the root cause analysis as well. This was working last week. You need to write here what broke the code. I am not asking for just identifying the single line which broke this code. Please do the analysis in following way:

What broke the code?
Identify the commit and developer who is responsible for that change.
What is the way that we can ensure that this code doesn't break again.
Don't just blindly fix by doing the reverse of code that broke it. There must be some reason for writing of that code.

Did we not just closed this issue?#4334

[jekram]

Is this issue related to performance issue: #5012

[saniasiddiqui]

I am able to send a test broadcast on production.
I'll discuss with @Muzamilbukhari to know the exact steps he is doing and see if he is still able to reproduce the bug in production.

[saniasiddiqui]

@Muzamilbukhari we can mark this issue as resolved, if this working fine.
Thanks

[Muzamilbukhari]

@saniasiddiqui Yes, this is working now. You may mark this as resolved.

[arveenkumar55]

I tested again today it is not working. @saniasiddiqui kindly look

[saniasiddiqui]

This seems to be broken by a recent change, while refactoring code for broadcast.
Commit Reference:
a0f1423#diff-1839017af204330c65d61d22e4f9be38.

I have fixed it, pull request is open.

[jekram]

@saniasiddiqui Please talk to @bjafri5 - He is moving this code in common broadcast logic

[saniasiddiqui]

I have tested this on staging. Working fine.
Assigning @arveenkumar55 for testing

[arveenkumar55]

working properly.

[arveenkumar55]

It is working on staging but not on production. we need to update production.

[arveenkumar55]

Working fine.