Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Group) logic on client to add member #369

Closed
sumairasaeed opened this issue Oct 14, 2016 · 6 comments
Closed

(Group) logic on client to add member #369

sumairasaeed opened this issue Oct 14, 2016 · 6 comments

Comments

@sumairasaeed
Copy link
Contributor

We should have the option to let the admin add new members to group after group is created. This would update the sqlite database and call the rest api to let the server know that member was added to group.

@sumairasaeed
Copy link
Contributor Author

I have completed work on this. Doing some testing. Will mark it resolved after testing IA.

@sumairasaeed
Copy link
Contributor Author

I tested and found there is a mistake on server side in one field in payload of push notification sent from server. Group Id returned in payload is incorrect. I have talked about it with @sojharo , he tried to correct it but issue is still there. Will test again tomorrow when server side error is corrected.
From client side, work is complete.

@sumairasaeed
Copy link
Contributor Author

This is done and working. The above comment was wrongly written here. it was meant for issue #373 .

@jekram jekram closed this as completed Oct 28, 2016
@sumairasaeed
Copy link
Contributor Author

The "Add Participants" button is slow with large addressbook. It is very similar to the issue we had with "New Group" and "Broadcast list" button . This needs to be fixed so re-opening this issue.
Here is screenshot of button:
image

@sumairasaeed sumairasaeed reopened this Dec 29, 2016
@jekram
Copy link
Contributor

jekram commented Dec 29, 2016

This is high priority needs to fixed right away

@sumairasaeed
Copy link
Contributor Author

This has been fixed now. Push is in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants