Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Search Chat) Write logic for searching chat messages #481

Closed
sumairasaeed opened this issue Feb 6, 2017 · 7 comments
Closed

(Search Chat) Write logic for searching chat messages #481

sumairasaeed opened this issue Feb 6, 2017 · 7 comments

Comments

@sumairasaeed
Copy link
Contributor

We need to implement Search on Chat messages as done on Android

@sumairasaeed
Copy link
Contributor Author

Renaming this task so we will write logic for searching chat messages here.
I have opened separate tasks for UI work of chat search #536 #535.

@sumairasaeed sumairasaeed changed the title Search Chat Feature (Search Chat) Write logic for searching chat messages Mar 15, 2017
@sumairasaeed
Copy link
Contributor Author

Spent most of time on this. This is in progress. Coded logic to search chat but was stuck in filtering data of group chat and 1-1 chat from using single search bar component. Need to look more into this.

@jekram
Copy link
Contributor

jekram commented Mar 16, 2017

What is the next step here?

@sumairasaeed
Copy link
Contributor Author

I have found a logic to cater this conflict. Also implemented the solution. Have created a single NSMutableArray and appended search results for both single or group chat. NSMutableArray will take care of different formats.
Now, I am able to get search chat results from both Single chats and group chats. Also results are now shown on UI. Thus, UI task #536 is also tested and working fine.
Here is KiboChat Search UI:
screen shot 2017-03-16 at 2 42 25 pm

Next step in this is that when user clicks on this chat message, it should be taken to whole conversation showing this message. This is what happens on whatsapp. It opens up whole conversation and conversation is scrolled up to that point where that searched chat message was.

@sumairasaeed
Copy link
Contributor Author

Now we are able to move to exact chat message position when we click on chat message that was searched. Also chat message is highlighted to point out. Remaining part is to do same for Groups chat.
Here is screenshot:
image

@jekram
Copy link
Contributor

jekram commented Mar 16, 2017

Thanks for the update

@sumairasaeed
Copy link
Contributor Author

This task has been completed now finally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants