File share UI work for sharing video as file attachment

[sumairasaeed]

Here we will do UI work needed for sharing Videos as file attachment

[sumairasaeed]

Exploring and reading up on it how video can be shown and played on UI of iOS. Will update more here.

[sumairasaeed]

Worked on this. Now it shows videos on UI when sharing files from where user can select the video to be shared.

[sumairasaeed]

Completed work on this. Understood implementation video component for playing videos. Created a sample application with the component and was able to play a sample video. Also created that component in our application.

[jekram]

So should we mark it resolved? If the work is complete.

[jekram]

I am assuming that design document and test matrix have been kept current. Correct?

Please send me screen shot of the test

[sumairasaeed]

Yes sir. design document is updated. Test matrix updated till last week. Will do more testing this week and update. Emailing you testing screenshots

[sumairasaeed]

Tested after completing #528 . Video is correctly shown if one video is shared. If more than one video shared, then it shows black area and video is not played. Reopening and looking into it

[jekram]

Did we not tested multiple videos before?

[sumairasaeed]

This has been fixed now. In this, we created and tested UI component for attaching and playing video inside player. Tested it by attaching video with an element.
Video plays as full screen when clicked. Same as in watsapp.

[jekram]

You did not answered my previous question?

Do you even read them or just chose to not answer them.

[sumairasaeed]

Sorry. It was missed.
No sir. Was not able to test iOS to Android.
Here are screenshots for test results

[jekram]

why we would not test with Android? when Android was getting developed there was no iOS so they could not test with iOS.

Would it not be logical to test with Android to make sure it is working? or you think we should do it later and reopen closed issues?

[sumairasaeed]

Thats right that we should test with Android also. I have Android 4.4 on my phone and KiboChat app does not run on it. I would carry out tests by borrowing from sojharo or dayem tomorrow in office IA whoever is available.

[jekram]

There are multiple ways to test. They do not need to be in the office. You can slack or email them. I would be happy also to test.

[jekram]

What is the status here? My expectations is that when I put comment that I get an response in a timely manner.

[sumairasaeed]

Video part on android is not merged. sojharo will merge it in a while. will test then

[jekram]

Ok

[sumairasaeed]

Tested. video sharing is working fine between android and iOS

[jekram]

Thanks for the update