Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addressbook when somebody joins Cloudkibo later #578

Closed
sumairasaeed opened this issue Mar 31, 2017 · 8 comments
Closed

Update addressbook when somebody joins Cloudkibo later #578

sumairasaeed opened this issue Mar 31, 2017 · 8 comments

Comments

@sumairasaeed
Copy link
Contributor

When somebody was not using KiboChat and start using it , it should be reflected in KiboChat address book

@jekram
Copy link
Contributor

jekram commented Mar 31, 2017

@sojharo Do you handle this in Android?

@sojharo
Copy link
Contributor

sojharo commented Mar 31, 2017

Dayem had written code to handle this. He was doing it in a different way. i.e. if person A is in my address book and he is not on kibochat. Later, when he joins kibochat and sends me a message. At that time I would update my address book to show person A as contact on cloudkibo. The other way is to get notification from server that person A has joined, this one can be done by using same dayem's logic. This time the logic would be called on notification from server. On Android, the other way is not done. It could be easily done in two lines of code as the update part is already done by @dayemsiddiqui . I would send the push notification from server and handle this work in server side issue. Therefore, I don't need same task to be opened for android as logic is already there by @dayemsiddiqui .

@sumairasaeed
Copy link
Contributor Author

Work on this has been completed

@jekram
Copy link
Contributor

jekram commented Apr 11, 2017

Is the testing complete

@jekram
Copy link
Contributor

jekram commented Apr 12, 2017

If testing is pending then "Work on this has been completed" is not accurate.

@sumairasaeed
Copy link
Contributor Author

Tested this with a new user number. Push is not received from server when new user joins cloudkibo later. Debugging and looking into it if there is some issue in registering tagname which listens for the push for new user.

@sumairasaeed
Copy link
Contributor Author

Debugged lot but couldnot catch any fault in client side logic. Tested on android with sojharo and it didnot work on android as well. Logic was rechecked on server and found a typo error on server-side logic. Also Azure hub didnot allow special character "_" in tagname. We were previously using "new_user" so it was then changed to "newuser" . Did Similar change on client side code and it worked fine.
We can close this now.

@jekram
Copy link
Contributor

jekram commented Apr 12, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants