Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach documents in broadcast list #613

Closed
sumairasaeed opened this issue Apr 28, 2017 · 8 comments
Closed

Attach documents in broadcast list #613

sumairasaeed opened this issue Apr 28, 2017 · 8 comments

Comments

@sumairasaeed
Copy link
Contributor

This task is to attach documents in broadcast chat message. The attachment will go to everybody in the broadcast list. We would cover both upload and download.
This is dependent on server side task Cloudkibo/CloudKibo#509

@jekram
Copy link
Contributor

jekram commented May 2, 2017

Why did we implemented broadcast without attachement

@sumairasaeed
Copy link
Contributor Author

Previously this was implemented using sending attachments in loop. When @sojharo started to work on it, he suggested more efficient way to do this using single endpoint. He has wrote a new endpoint on server for sending attachments in broadcast using single API call. Cloudkibo/CloudKibo#509 . Need to modify client side code accordingly.

@jekram
Copy link
Contributor

jekram commented May 2, 2017

Ok. The description is misleading then. This task is a re-implementation then.

@jekram
Copy link
Contributor

jekram commented May 5, 2017

what is the status of this? When you show any test on today's list then you need to update what was done and what was not done.

You have already implemented attached document logic so why we are NOT LEVERAGING TOSE WORK AND CLOSING THEM. THIS IS NOT A GAME

@sumairasaeed
Copy link
Contributor Author

Was not able to work on this yesterday. Completed and tested code for upload. Completed code for downloading. Needs some testing

@jekram
Copy link
Contributor

jekram commented May 5, 2017

So this is not complete?

@sumairasaeed
Copy link
Contributor Author

This has been completed

@jekram
Copy link
Contributor

jekram commented May 7, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants