[FLOC-4552] Harden EBS tag parsing #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a volume in EBS with a tag key of `flocker-dataset-id` but the value is not a valid UUID, any Flocker agent connected to that account will throw an exception during iteration and will be unusable. The change here catches bad values and makes them process as just another volume that's not part of the asking cluster rather than throwing the mentioned exceptions.
…-4552-harden_ebs_tag_parsing
|
Well that went badly. |
|
@sgnn7 Please review the changes in the branch and leave comments and / or a LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://clusterhq.atlassian.net/browse/FLOC-4552
Based on #2973 with some extra logging and unit tests.
Thanks to @sgnn7 for reporting this issue and providing a patch.