Skip to content

Commit b542a8f

Browse files
committed
Log: controld: Show action timer plus cluster-delay in action_timer cb
`action_timer_callback()` prints a misleading error message. If it times out waiting for an action result, the error message prints the timeout value followed by "(action timeout plus cluster-delay)". However, only the `action->timeout` value is displayed. `cluster-delay` is not added in. Resolves: RHBZ#1856035
1 parent 813fdbf commit b542a8f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

daemons/controld/controld_te_callbacks.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,8 @@ action_timer_callback(gpointer data)
697697
crm_err("Node %s did not send %s result (via %s) within %dms "
698698
"(action timeout plus cluster-delay)",
699699
(on_node? on_node : ""), (task? task : "unknown action"),
700-
(via_node? via_node : "controller"), timer->timeout);
700+
(via_node? via_node : "controller"),
701+
timer->timeout + transition_graph->network_delay);
701702
print_action(LOG_ERR, "Aborting transition, action lost: ", timer->action);
702703

703704
timer->action->failed = TRUE;

0 commit comments

Comments
 (0)