Fix incorrect test for domain name in VirtualDomain #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Haas <florian.haas@linbit.com>
|
Merged |
ghost
mentioned this pull request
akurz
referenced
this pull request
in akurz/resource-agents
Jun 14, 2014
redis: bring up in slave mode
Closed
krig
pushed a commit
that referenced
this pull request
Jun 30, 2017
ytakeshita
pushed a commit
to ytakeshita/resource-agents
that referenced
this pull request
Dec 8, 2017
remove an unnecessary file which is created by ./configure. close ClusterLabs#1
ytakeshita
pushed a commit
to ytakeshita/resource-agents
that referenced
this pull request
Dec 8, 2017
Low: stonith-helper: Skip standby_wait when target node is online.
oalbrigt
pushed a commit
that referenced
this pull request
Jul 27, 2018
merge current project into own fork
nrwahl2
pushed a commit
to nrwahl2/resource-agents
that referenced
this pull request
Nov 29, 2018
The docker RA's stop operation doesn't behave properly in some cases.
1. It returns a false success code in case of an error response from
the daemon.
2. It fails at `remove_container()` if the container does not exist
but another docker object of the same name does exist.
In case ClusterLabs#1, the `container_exists()` function returns the same exit code
(1) if the container is not found (an expected error) or if there is an
error response from the docker daemon (an unexpected error). These types
of errors should be handled differently.
In case ClusterLabs#2, the `docker inspect` calls do not limit their search to
containers. So if a non-container object is found with a matching name,
the RA attempts to remove a container by that name. Such a container may
not exist.
This patch fixes these issues as follows:
1. Match an error response in `container_exists()` against the string
"No such container".
2. Add `--type=container` to the `docker inspect` calls to restrict
the match.
nrwahl2
pushed a commit
to nrwahl2/resource-agents
that referenced
this pull request
Jan 3, 2019
The docker RA's stop operation doesn't behave properly in some cases.
1. It returns a false success code in case of an error response from
the daemon.
2. It fails at `remove_container()` if the container does not exist
but another docker object of the same name does exist.
In case ClusterLabs#1, the `container_exists()` function returns the same exit code
(1) if the container is not found (an expected error) or if there is an
error response from the docker daemon (an unexpected error). These types
of errors should be handled differently.
In case ClusterLabs#2, the `docker inspect` calls do not limit their search to
containers. So if a non-container object is found with a matching name,
the RA attempts to remove a container by that name. Such a container may
not exist.
This patch fixes these issues as follows:
1. Match an error response in `container_exists()` against the string
"No such container".
2. Add `--type=container` to the `docker inspect` calls to restrict
the match.
nrwahl2
pushed a commit
to nrwahl2/resource-agents
that referenced
this pull request
Jan 3, 2019
The docker RA's stop operation doesn't behave properly in some cases.
1. It returns a false success code in case of an error response from
the daemon.
2. It fails at `remove_container()` if the container does not exist
but another docker object of the same name does exist.
In case ClusterLabs#1, the `container_exists()` function returns the same exit code
(1) if the container is not found (an expected error) or if there is an
error response from the docker daemon (an unexpected error). These types
of errors should be handled differently.
In case ClusterLabs#2, the `docker inspect` calls do not limit their search to
containers. So if a non-container object is found with a matching name,
the RA attempts to remove a container by that name. Such a container may
not exist.
This patch fixes these issues as follows:
1. Match an error response in `container_exists()` against the string
"No such container".
2. Add `--type=container` to the `docker inspect` calls to restrict
the match.
oalbrigt
pushed a commit
that referenced
this pull request
Jan 29, 2020
Medium: pgsql: Remove standby.signal when promote with restart
tabraham
added a commit
to tabraham/resource-agents
that referenced
this pull request
Jul 17, 2023
Parsing mount command output in list_mounts() results in a sed error: sed: -e expression ClusterLabs#1, char 51: invalid reference \5 on `s' command's RHS This results in a list_mounts not returning any mounts. The error is caused due to match_string only providing three capture groups, while the replacement string references a non-existing 5th capture group. Also, the output for this case differs from the case where the mount list is parsed from /proc/mounts or /etc/mtab as it would include the mount options in the output. Fixes: a8051cf ("Filesystem: Support whitespace in device or directory name")
tabraham
added a commit
to tabraham/resource-agents
that referenced
this pull request
Jul 17, 2023
Parsing mount command output in list_mounts() results in a sed error: sed: -e expression ClusterLabs#1, char 51: invalid reference \5 on `s' command's RHS This results in a list_mounts not returning any mounts. The error is caused due to match_string only providing three capture groups, while the replacement string references a non-existing 5th capture group. Also, the output for this case differs from the case where the mount list is parsed from /proc/mounts or /etc/mtab as it would include the mount options in the output. Fixes: a8051cf ("Filesystem: Support whitespace in device or directory name")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple one-liner that fixes an incorrect invocation of "test -n".