IPaddr2/findif.sh: improvements of error checks #156

Merged
merged 6 commits into from Oct 24, 2012

Conversation

Projects
None yet
4 participants
@kskmori
Contributor

kskmori commented Oct 22, 2012

This pull request improves error checks in IPaddr2/findif.sh, including fixes for comments below:

Thanks,

@dmuhamedagic

This comment has been minimized.

Show comment Hide comment
@dmuhamedagic

dmuhamedagic Oct 22, 2012

Local variables are typically lowercase. Obviously, this is just a style observation, but it may be good to consider later.

Local variables are typically lowercase. Obviously, this is just a style observation, but it may be good to consider later.

This comment has been minimized.

Show comment Hide comment
@dmuhamedagic

dmuhamedagic Oct 22, 2012

In order to avoid potential confusion, that is :)

In order to avoid potential confusion, that is :)

This comment has been minimized.

Show comment Hide comment
@kskmori

kskmori Oct 23, 2012

Owner

Right. I've added a commit d2a7772 for fixing it.

Owner

kskmori replied Oct 23, 2012

Right. I've added a commit d2a7772 for fixing it.

@dmuhamedagic

This comment has been minimized.

Show comment Hide comment
@dmuhamedagic

dmuhamedagic Oct 22, 2012

Contributor

On Sun, Oct 21, 2012 at 11:20:10PM -0700, Keisuke MORI wrote:

This pull request improves error checks in IPaddr2/findif.sh, including fixes for comments below:

  • fix error check for cidr_netmask pointed out by jnpkrn at #154

Very good to have this testing facility now!

-- Commit Summary --

  • Low: findif.sh: do error checking for cidr_netmask properly.

Hmm, wonder how this slipped, anyway good to have it rectified.

  • Low: IPaddr2: keep code consistency
  • Medium: findif.sh: Add error log messages for parameter checks.
  • Low: findif.sh: move parameter checks to a function
  • Low: findif.sh: Simplify error checks to reduce command executions.

Looks good to me.

Contributor

dmuhamedagic commented Oct 22, 2012

On Sun, Oct 21, 2012 at 11:20:10PM -0700, Keisuke MORI wrote:

This pull request improves error checks in IPaddr2/findif.sh, including fixes for comments below:

  • fix error check for cidr_netmask pointed out by jnpkrn at #154

Very good to have this testing facility now!

-- Commit Summary --

  • Low: findif.sh: do error checking for cidr_netmask properly.

Hmm, wonder how this slipped, anyway good to have it rectified.

  • Low: IPaddr2: keep code consistency
  • Medium: findif.sh: Add error log messages for parameter checks.
  • Low: findif.sh: move parameter checks to a function
  • Low: findif.sh: Simplify error checks to reduce command executions.

Looks good to me.

dmuhamedagic added a commit that referenced this pull request Oct 24, 2012

Merge pull request #156 from kskmori/IPaddr2-dualstack-improve-error-…
…check

IPaddr2/findif.sh:  improvements of error checks

@dmuhamedagic dmuhamedagic merged commit 6f7b7b9 into ClusterLabs:master Oct 24, 2012

@jnpkrn

This comment has been minimized.

Show comment Hide comment
@jnpkrn

jnpkrn Oct 24, 2012

Contributor

Keisuke, please see recent #154 (comment) comment.

Contributor

jnpkrn commented Oct 24, 2012

Keisuke, please see recent #154 (comment) comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment