IPaddr2/findif.sh: improvements of error checks

[kskmori]

This pull request improves error checks in IPaddr2/findif.sh, including fixes for comments below:

• fix error check for cidr_netmask pointed out by jnpkrn at Low: test-findif: findif.sh+IPv6 support, portable, working... #154
• simplify error checks proposed by lge in the ML http://www.gossamer-threads.com/lists/linuxha/dev/82242 (with a bit modification)

Thanks,

[dmuhamedagic]

On Sun, Oct 21, 2012 at 11:20:10PM -0700, Keisuke MORI wrote:

This pull request improves error checks in IPaddr2/findif.sh, including fixes for comments below:

• fix error check for cidr_netmask pointed out by jnpkrn at Low: test-findif: findif.sh+IPv6 support, portable, working... #154

Very good to have this testing facility now!

• simplify error checks proposed by lge in the ML http://www.gossamer-threads.com/lists/linuxha/dev/82242 (with a bit modification)

-- Commit Summary --

• Low: findif.sh: do error checking for cidr_netmask properly.

Hmm, wonder how this slipped, anyway good to have it rectified.

• Low: IPaddr2: keep code consistency
• Medium: findif.sh: Add error log messages for parameter checks.
• Low: findif.sh: move parameter checks to a function
• Low: findif.sh: Simplify error checks to reduce command executions.

Looks good to me.

[jnpkrn]

Keisuke, please see recent #154 (comment) comment.