This repository has been archived by the owner on Nov 2, 2020. It is now read-only.
handleUpgrade wasn't compatible with WS spec #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handleUpgrade wasn't compatible with WS module spec
goriunov
suggested changes
Dec 30, 2018
lib/cws/server.ts
Outdated
| @@ -26,6 +26,8 @@ export class WebSocketServer extends eventEmitter() { | |||
| if (configs.path && configs.path[0] !== '/') { | |||
| configs.path = `/${configs.path}`; | |||
| } | |||
|
|
|||
| this._upgradeCallback = noop; | |||
There was a problem hiding this comment.
Can you rename variables to just upgradeCallback and move at the top with private tag (it is TypeScript not a JS so it has slightly different approach in creating variables) for reference check out upgradeListener variable.
lib/cws/server.ts
Outdated
| @@ -151,7 +154,7 @@ export class WebSocketServer extends eventEmitter() { | |||
| return socket.end(`HTTP/1.1 ${code} ${name}\r\n\r\n`); | |||
| } | |||
|
|
|||
| private handleUpgrade(req: HTTP.IncomingMessage, socket: Socket): void { | |||
| private handleUpgrade(req: HTTP.IncomingMessage, socket: Socket, upgradeHead, callback): void { | |||
There was a problem hiding this comment.
You need to specify types for upgradeHead and callback
lib/cws/server.ts
Outdated
| @@ -165,6 +168,7 @@ export class WebSocketServer extends eventEmitter() { | |||
| if (!this.serverGroup) return; | |||
|
|
|||
| this.upgradeReq = req; | |||
| this._upgradeCallback = callback ? callback : noop; | |||
There was a problem hiding this comment.
This is probably easier to write this._upgradeCallback = callback || noop;
added 2 commits
January 3, 2019 21:28
|
@goriunov: is it allright now? |
goriunov
reviewed
Jan 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleUpgrade wasn't compatible with WS module spec