Fix ConnectionInfo type (origin -> headers), added typings #4

tmcgannon · 2018-09-15T00:41:26Z

Fix ConnectionInfo type (in types.ts, 'origin' property was not updated to 'headers'). Added typings.

goriunov · 2018-09-15T01:41:35Z

Thanks for pull req, can you also add HTTPS typings (HTTP | HTTPS). So that we can proved http or https server.

tmcgannon · 2018-09-16T19:33:23Z

Added HTTP | HTTPS. Also, added types to handleUpgrade() - kind of a hack since you are accessing private net.Socket properties.

goriunov · 2018-09-16T19:47:24Z

lib/types.ts

@@ -20,7 +22,7 @@ export type ServerConfigs = {
  path?: string,
  port?: number,
  host?: string,
-  server?: any,
+  server?: HTTP.Server,


Need to add https here too

tmcgannon · 2018-09-16T23:07:13Z

Sorry for that miss. HTTPS typing has been added to types.ts.

goriunov · 2018-09-17T05:05:40Z

Looks good to me :) Thank you.

Fix ConnectionInfo type (origin -> headers), added typings

7d5b26c

goriunov self-assigned this Sep 15, 2018

Add type declarations for HTTPS

fcf9e68

goriunov reviewed Sep 16, 2018

View reviewed changes

Add HTTP.Server | HTTPS.Server typing to types.ts

aa3e1d7

goriunov merged commit 0bd8e26 into ClusterWS:master Sep 17, 2018

Provide feedback