HFT integration -> master #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2021
nicklambourne
approved these changes
Dec 5, 2021
* do quotes * change quotes in hft model.py * some more quotes * another one
* keep log file scrolled to bottom * stage status stuff * remove commented lines * avoid index out of range error when getting results * remove a print * remove stage logs from error handling bit * still faililng * more things
elpis/engines/kaldi/objects/model.py
Outdated
| self.config['stage_count'] = self.config['stage_count'] + 1 | ||
| except CalledProcessError as error: | ||
| with open(stage_log_path, 'a+') as file: | ||
| with open(self.run_log_path, 'a+') as file: | ||
| print('stderr', error.stderr, file=file) | ||
| print('failed', file=file) | ||
| print(f"Stage {stage} failed") | ||
| self.stage_status = (stage, 'failed', '', 'LOG-C') |
There was a problem hiding this comment.
I think this will cause an error after the refactor which removes the final two arguments from this setter.
There was a problem hiding this comment.
well spotted. I've removed the two final.
self.stage_status = (stage, 'failed')
harrykeightley
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉