Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buttons to individually remove datasets, pron dicts and models #279

Merged
merged 7 commits into from
Dec 23, 2021

Conversation

mattchrlw
Copy link
Contributor

Closes #138.

  • Deletion is done in a cascading manner, that is:
    • Deleting a dataset deletes pron dicts and models that use it.
    • Deleting a pron dict deletes models that use it.
  • Deletion is done at a file level, so clicking delete not only removes it from self.config but also uses shutil.rmtree.
  • The UI for selection and deletion has also been standardised across the UI for consistency.
  • Bug fixes where a user could proceed past the training stage where there is no datasets, for example.
  • Loading logic has been adjusted so you can select a dataset, pron dict or model that has not been initialised.

@mattchrlw
Copy link
Contributor Author

Pretty pictures!
image
image
image

@benfoley
Copy link
Contributor

This is sooo good to have. Probably good to have a "are you sure" popup (as annoying as they are) but that can come later.

Copy link
Contributor

@benfoley benfoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice bonus bug fixes

@benfoley benfoley merged commit 862d436 into master Dec 23, 2021
@harrykeightley harrykeightley deleted the matt-remove-buttons branch October 6, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ui to delete models/pron_dicts/datasets
2 participants