Skip to content
This repository has been archived by the owner on May 18, 2023. It is now read-only.

Fix trainer subscription #86

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Fix trainer subscription #86

merged 1 commit into from
Oct 14, 2022

Conversation

harrykeightley
Copy link
Collaborator

@harrykeightley harrykeightley commented Oct 13, 2022 •
edited
Loading

Fixes #85

  • Makes trainer service return an ack response as soon as it assembles a valid ModelMetadata instance.
  • Update the google provider versions in terraform to enable exactly_once_delivery on the topic subscription.
  • Increase the ack_deadline_seconds to 30.
  • Add tests for hitting / with various request formats.
  • Minor refactor of logging and responses in trainer service.

@harrykeightley harrykeightley self-assigned this Oct 13, 2022
@harrykeightley harrykeightley marked this pull request as ready for review October 14, 2022 02:33
nicklambourne
nicklambourne approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@nicklambourne nicklambourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ suggestions

services/trainer/trainer/main.py Outdated Show resolved Hide resolved
services/trainer/trainer/main.py Show resolved Hide resolved
@harrykeightley
Fix trainer subscription:
9a2ec3b 
- Return a http response before performing training flow.
- Update google versions
- Add tests for calling flask "/" route
- Update http status codes to be non-magic
@harrykeightley harrykeightley merged commit 8dbcd06 into main Oct 14, 2022
@harrykeightley harrykeightley deleted the fix_trainer_subscription branch October 14, 2022 06:18
@harrykeightley harrykeightley mentioned this pull request Oct 14, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicklambourne nicklambourne nicklambourne approved these changes

Assignees

@harrykeightley harrykeightley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trainer pubsub subscription retries thousands of times before getting a response.
2 participants
@harrykeightley @nicklambourne