Fixing split card from UNH with wrong name in database (fix #2947) #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: common/decklist.cpp modified: common/decklist.h
Added extra case to handle the card Who/What/When/Where/Why.
|
Seems to work for both services! Thanks again for a quick fix with a very detailed description. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Short roundup of the initial problem
The card Who/What/When/Where/Why has the wrong name when it is generated in the database. Oracle defaults to the separator " // " for all split cards, which produces the wrong name for this card alone. This caused problems when exporting a list containing that card to Tappedout or Deckstats, with Tappedout failing due to the unknown card and Deckstats generating a link but with an unknown card in it.
What will change with this Pull Request?
The card name generation is modified for split/aftermath cards with more than 2 components to use the separator "/" instead of " // ". Deckstats and Tappedout generation now works for this card (and the 63 other split cards). The fix would affect any possible future split card with 3 sub-cards, but in principle such a situation would probably require this piece of code to be revisited anyway and adjusting this UNH card fix might not be an issue.
Screenshots
Tappedout
Deckstats