-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim token file down on not needed extra entries #102
Comments
First, let's reviewThere is a "default" for every card that produces tokens. If a card produces multiple types tokens at once, ( Then there are cards produce different tokens from different abilities, or under a different circumstance. When that happens, only one of those abilities can be designated the default; all the others must be marked with the For example, it won't make sense for the "all tokens" shortcut to create both token creatures and emblems for many planeswalkers in the same keypress. (Search text = "Unnecessary" entriesSome tokens have extra entries added for convenience for the same type of token. These are tokens intended to have a "sensible default" when using the "All Tokens" shortcut, but have an extra option in the context menu if the player wants to use that instead. These are:
DiscussionWith Are you suggesting all of these examples should be replaced with a single Let's take Her default entry is as expected. The create token shortcut creates a single 1/1 white Human Warrior creature token. This reasoning is the exact same used when a second entry was added to Is the extra effort on my part more of a hindrance to a player with a card like this? |
Those make the token file and the right click UI in Cockatrice more complex.
E.g. Scute Swarm has a "normal" and a "x" entry.
The x entry should be enough as it covers all cases, it also defaults to "1" as the most needed one.
That way the current "exclude" tag for the "x" entry is also not needed and the default token shortcut still works.
It's even reasonable to argue the "normal" case is the best here and the edge case for several lands entering the battlefield at once (before they have 6 lands in play) is super rare.
As Psi states, there are probably more of those.
A good starting point might be to check which cards have more than one entry and go from there.
The text was updated successfully, but these errors were encountered: