-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation #111
Comments
I suggested adding a github action that simply automates all of this simple formatting stuff, ordering things is something computers should do, not humans |
I totally support that! There should probably still be some docs about the rules being applied/wanted. Would you rather have a checking GH Action that notifies about misalignments that the PR creator should take care of with a script we provide (like the Cockatrice lint action?), or one that actually applies the preferred sorting rules and commits the changes right to the pr/repo (or probably better: creates a PR so that we can check again)? The last (commit to repo) could run e.g. on push to master, scheduled once every week or triggered manually... |
I don't really think the version should be changed except by the person merging a branch into master. It's not a useful request, because the author doesn't know when or if their pull request will be merged. |
True. That is a totally valid point!
I agree with you on the time when such an update should happen. However, there are ways around enforcing a manual human action there and skipping the potential mistakes involved or forgetting it altogether. I agree with ebbit here and think the date update is also "something computers should do, not humans". |
actions can be triggered by merging |
Expand on file documentation in the wiki (https://github.com/Cockatrice/Magic-Token/wiki#documentation) and create and curate a new page.
Also include info about structure, layout and sorting.
The example card comment is also probably better off in the wiki next to its explanation and further details, and only have a link to all doc resource in the token file instead:
https://github.com/Cockatrice/Magic-Token/blob/master/tokens.xml#L15-L32
Place a link in the readme.
Helpful infos and hints for potential guidelines:
related
beforereverse-related
, sorting (67a2d6c
(#108))count
beforeexclude
(543b96c
(#108))spaces
>tabs
indentation (fb31047
(#108))related
vs.reverse-related
(AFR (and most of AFC) Tokens #108 (comment), Remove all <related> for <reverse-related> #119, --> 67b20ab)
If a card has several occurrences, there probably needs to be exclude tags?
When (or after all) to use
count="x=1"
?(MIC and MID Tokens #114 (comment), CLB Tokens #147 (review))
count="x=0"
at all? (Trim token file down on not needed extra entries #102 + Remove x=0 values #101)<set>SETCODE</set>
vs.<set picURL="">SETCODE</set>
?(Kamigawa Tokens #134 --> remove misspellings of picURL #150, CLB Tokens #147 (comment))
&
, see CLB Tokens #147 (comment)The text was updated successfully, but these errors were encountered: