Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #111

Open
tooomm opened this issue Jul 11, 2021 · 5 comments
Open

Improve documentation #111

tooomm opened this issue Jul 11, 2021 · 5 comments

Comments

@tooomm
Copy link
Contributor

tooomm commented Jul 11, 2021

Expand on file documentation in the wiki (https://github.com/Cockatrice/Magic-Token/wiki#documentation) and create and curate a new page.
Also include info about structure, layout and sorting.

The example card comment is also probably better off in the wiki next to its explanation and further details, and only have a link to all doc resource in the token file instead:
https://github.com/Cockatrice/Magic-Token/blob/master/tokens.xml#L15-L32

Place a link in the readme.

Helpful infos and hints for potential guidelines:

@ebbit1q
Copy link
Member

ebbit1q commented Jul 14, 2021

I suggested adding a github action that simply automates all of this simple formatting stuff, ordering things is something computers should do, not humans

@tooomm
Copy link
Contributor Author

tooomm commented Jul 14, 2021

ordering things is something computers should do, not humans

I totally support that!
Mentioned some potential other ideas in the linked issue as well. Most noticeable the ability to check if the date/version got updated, which people easily forget. :)
Also something that could be applied automatically right away.

There should probably still be some docs about the rules being applied/wanted.

Would you rather have a checking GH Action that notifies about misalignments that the PR creator should take care of with a script we provide (like the Cockatrice lint action?), or one that actually applies the preferred sorting rules and commits the changes right to the pr/repo (or probably better: creates a PR so that we can check again)?

The last (commit to repo) could run e.g. on push to master, scheduled once every week or triggered manually...

@Psithief
Copy link
Contributor

I don't really think the version should be changed except by the person merging a branch into master. It's not a useful request, because the author doesn't know when or if their pull request will be merged.

@tooomm
Copy link
Contributor Author

tooomm commented Jul 15, 2021

the author doesn't know when or if their pull request will be merged.

True. That is a totally valid point!

I don't really think the version should be changed except by the person merging a branch into master.

I agree with you on the time when such an update should happen.

However, there are ways around enforcing a manual human action there and skipping the potential mistakes involved or forgetting it altogether.
As noted, the CI can run e.g. on every push event on master (direct commit, PR merged) and update the date automatically the minute after. Or check e.g. on a daily schedule if changes happened and update the date with the last commit date etc.

I agree with ebbit here and think the date update is also "something computers should do, not humans".

@ebbit1q
Copy link
Member

ebbit1q commented Jul 24, 2021

actions can be triggered by merging

@tooomm tooomm mentioned this issue Sep 22, 2021
9 tasks
@tooomm tooomm linked a pull request Jun 2, 2022 that will close this issue
9 tasks
@tooomm tooomm removed a link to a pull request Jun 2, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants