Skip to content
This repository has been archived by the owner on Nov 3, 2020. It is now read-only.

Fix OpenSSL issue in bundled Ruby #281

Merged
merged 1 commit into from
Apr 8, 2016
Merged

Fix OpenSSL issue in bundled Ruby #281

merged 1 commit into from
Apr 8, 2016

Conversation

ohayon
Copy link
Contributor

@ohayon ohayon commented Apr 8, 2016

This fixes #280 and #271 .

@orta
Copy link
Member

orta commented Apr 8, 2016

Oh nice!

@ohayon ohayon mentioned this pull request Apr 8, 2016
@ohayon
Copy link
Contributor Author

ohayon commented Apr 8, 2016

Looks like CI is failing on downloading SVN. 😕. I am more than happy to fix that if you don't mind two things in the PR?

@orta
Copy link
Member

orta commented Apr 8, 2016

I'm seeing it locally

/tmp ⏛  /usr/bin/curl -sSL https://archive.apache.org/dist/subversion/subversion-1.8.13.tar.gz -o downloads/subversion-1.8.13.tar.gz
curl: (23) Failed writing body (0 != 512)

Yep - we've experienced these hosts going down before, and talked about storing the downloads as a separate repo

@alloy
Copy link
Member

alloy commented Apr 8, 2016

Great work 👍

The SVN issue is just a temp one, see https://archive.apache.org/dist/subversion “This service is currently undergoing maintenance!”

@alloy alloy merged commit cb66912 into CocoaPods:master Apr 8, 2016
@ohayon
Copy link
Contributor Author

ohayon commented Apr 8, 2016

Ohh, interesting. In the work that I've been doing I have changed a bit about what is getting built into the bundle (i.e. removed svn, git, and some others) I would love to know more about why you are including all those extra tools inside the bundle? It might be something that I do in fact need but am not aware of.

@orta
Copy link
Member

orta commented Apr 8, 2016

yeah, I think that's fine - I was about to say this is mergable too

screen shot 2016-04-08 at 20 59 37

@alloy
Copy link
Member

alloy commented Apr 8, 2016

CocoaPods supports downloading from SVN, Mercurial, etc. Sometimes people have older versions. The whole point of this app is to be able to use it in any env, no matter what the user does or does not have installed.

@ohayon
Copy link
Contributor Author

ohayon commented Apr 8, 2016

Ahh, that makes sense! Thanks for all your help today! 👍 🎉 🌴

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundled Ruby Question
3 participants