Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inhibit_all_warnings adds incorrect flags for Dtrace (.d) files #1510

Closed
PaulTaykalo opened this issue Oct 25, 2013 · 2 comments
Closed

inhibit_all_warnings adds incorrect flags for Dtrace (.d) files #1510

PaulTaykalo opened this issue Oct 25, 2013 · 2 comments

Comments

@PaulTaykalo
Copy link

Some projects contains not only .m an .h files, but .d files also
When in main Podfile we're setting inhibit_all_warnings! it will automatically add
flags << '-w -Xanalyzer -analyzer-disable-checker'
flags << '-fobjc-arc'
for all files that were specified in podspec.
This is ok for '.m, .mm' files but is definetely not ok for '.d' files.

So suggestion is to check for which files we're adding these flags, and skip ".d" files or add flags for .m, .mm, .c files only .

File were changes is need to be performed:
https://github.com/CocoaPods/CocoaPods/blob/master/lib/cocoapods/installer/target_installer/pod_target_installer.rb

As far as I see for now flags are generated for all files those are related for consumer. But somehow there's a need to skip files with .d

EXAMPLE of the fix is here (Sorry, I'm not a rubyist or something)

PaulTaykalo@fa039c1

Issue that relates to this CocoaPods behaviour.
ReactiveCocoa/ReactiveCocoa#866

@alloy
Copy link
Member

alloy commented Oct 25, 2013

Thanks for the feedback and example of the issue.

@fabiopelosin
Copy link
Member

Closed via 740dfc7.

@kylef kylef closed this as completed Nov 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants