[Plugins] Added support for hooks registratrion #1755
Conversation
|
|
||
| # Simple hook system for plugins. | ||
| # | ||
| # The system is based around the concept that plugins can |
There was a problem hiding this comment.
The system is based around the concept that - this says nothing, kill it with 🔥
|
@alloy other than moving the data to Ruby objects, do you have any comment about this one? |
|
Needs a rebase too |
Done |
|
needs a second rebase, hah, but yeah, would definitely love to have this in, got plans to build something relying on this soon. |
|
Second rebase? |
|
Ok, this should be done. I'm leaving the usual 24h window to the rest of the @CocoaPods/core team so they can express any of their concerns to avoid a maintenance disaster! |
|
PS: This pull request has been completely rewritten and amended. |
| @@ -6,7 +6,20 @@ To install or update CocoaPods see this [guide](http://docs.cocoapods.org/guides | |||
|
|
|||
| ##### Enhancements | |||
|
|
|||
| * Display indication for deprecated pods when searching for Pods. | |||
| * Added hooks for plugins. Currently only the installer hook is supported. | |||
There was a problem hiding this comment.
As discussed in the chat channel, because it’s a hook that’s only used in very rare occasions and we don’t need to expose more than what’s actually needed atm.
|
👍 |
[Plugins] Added support for hooks registratrion
|
YAY |
Living TODO
Pluginsmodule toHooksManager