Gist https validation error

[keith]

Seems like there is an error when linting a spec that points to gist.github.com. Even when the spec points to the https link the validation fails. Lint output https://travis-ci.org/CocoaPods/Specs/builds/13016103#L169 for spec https://github.com/timshadel/Specs/blob/d9d26c59d80cf63ac121419371f32380b1c6a8ce/UIImageEffects/0.0.1/UIImageEffects.podspec

CocoaPods/Specs#3509
CocoaPods/Specs#4946

[keith]

Error is right here

Core/lib/cocoapods-core/specification/linter.rb

Line 251 in 8b1ace0

warning "Github repositories should use `https` link." if github && !git.start_with?('https://github.com') && !git.start_with?('git://gist.github.com')

Instead of:

if github && !git.start_with?('https://github.com') && !git.start_with?('git://gist.github.com')

It should read either:

if github && !git.start_with?('https://github.com') && !git.start_with?('https://gist.github.com')

Or simply just:

if github && !git.start_with?('https://')

[orta]

there are some podspecs that exist that are gists, I wonder why they aren't failing

[keith]

I added them to the Whitelist this first time this came up.

[keith]

https://github.com/CocoaPods/Specs/blob/master/Rakefile#L138-L141

[joshkalpin]

@Keithbsmiley I'll have a fix for it tomorrow.

[fabiopelosin]

👍