Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ParseKit podspec #125

Merged
merged 3 commits into from
Apr 19, 2012
Merged

Added ParseKit podspec #125

merged 3 commits into from
Apr 19, 2012

Conversation

digal
Copy link
Contributor

@digal digal commented Apr 19, 2012

Homepage: http://parsekit.com/
GH: https://github.com/itod/parsekit

Note: pod spec lint fails due to https://github.com/cocoapods/specs/issues/110, but passes if the condition is commented out. I've also smoke-tested it with my iOS project, and it seem to work.

@@ -0,0 +1,39 @@
Pod::Spec.new do |s|
s.name = 'ParseKit'
s.version = '1.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specs without version tags should be added as 0.0.1

@digal
Copy link
Contributor Author

digal commented Apr 19, 2012

changed version to 0.0.1

@SevInf
Copy link
Contributor

SevInf commented Apr 19, 2012

Good. What about asking the author to add tags?

@digal
Copy link
Contributor Author

digal commented Apr 19, 2012

Wow, you even have a template for this! Thanks.

The template assumes that podspec should be in the Specs repo. Should I wait for merge before filing the issue?

@digal
Copy link
Contributor Author

digal commented Apr 19, 2012

Ok, I think I'll give a link to this pull request.

@digal
Copy link
Contributor Author

digal commented Apr 19, 2012

Here it is: itod/parsekit#12

@SevInf SevInf merged this pull request into CocoaPods:master Apr 19, 2012
@SevInf
Copy link
Contributor

SevInf commented Apr 19, 2012

Thank you. Spec merged, and you have push access to this repo now.

@SevInf
Copy link
Contributor

SevInf commented Apr 19, 2012

@siuying, why did you rolled back this commit?

@siuying
Copy link
Contributor

siuying commented Apr 19, 2012

@SevInf I'm sorry i made a mistake on this... I'm not intended to overwrite the commit

@siuying
Copy link
Contributor

siuying commented Apr 19, 2012

@SevInf Could you roll it back?

SevInf pushed a commit that referenced this pull request Apr 19, 2012
@SevInf
Copy link
Contributor

SevInf commented Apr 19, 2012

Done. @siuying, actually you should never use push --force with a public repo with many contributors, such as this one. There may be some commits since you pulled last time, and they will completely disappear from history. It will be possible to recover them only if someone has this commits in their local repo.

@siuying
Copy link
Contributor

siuying commented Apr 19, 2012

@SevInf thanks. understood and noted carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants