New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add] LibComponentLogging-pods 0.0.2 #12835
Conversation
adapt lcl_configure to new location of build headers in CocoaPods 0.34.x and 0.35.x
FWIW doing it this way won't get added to web properties ( e.g. search, cocoadocs etc ) but would still work fine generally. Do you know if there's anything we can do to make it lint correctly? ( /cc @kylef ) |
A trunk lint --quick option would be cool, just like pod spec lint has. Building an Xcode project requires some config files which don't exist in a plain project. So, I assume that all related specs couldn't be updated via trunk at the moment. |
What also could help would be a possibility to add something locally to the Podfile which is created and used by pod trunk push. Then I could add the auto-configuration pod and a post-install hook which could create the config files. |
@orta @kylef adding the following lines to the Podfile which is used by
BTW is linting always using the folder |
@aharren You could make a CocoaPods plugin which add's this hook, as of version 0.36 you will need to explicitly define which plugins you want in your Podfile which means you'd have the same problem. I'm wondering if we can add a That, or we could allow you to create the Podfile manually and pass it to the linter. @kapin, what do you think? You are right, currently it will fail if you try linting two things at once. I'd normally use |
@kylef I feel like that would be a massive change for the linter. I'm kind of concerned about the long-term effects of that too. I'm just getting into exam season, so I can't really look into it until the middle of December. |
[Add] LibComponentLogging-pods 0.0.2
Thx.
@kylef I was thinking about a continuous integration environment where multiple pod calls may run in parallel (for different jobs). I'll have a look at the mentioned lines. |
adapt lcl_configure to new location of build headers in CocoaPods 0.34.x and 0.35.x