Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] LibComponentLogging-pods 0.0.2 #12835

Merged
merged 1 commit into from Dec 1, 2014
Merged

[Add] LibComponentLogging-pods 0.0.2 #12835

merged 1 commit into from Dec 1, 2014

Conversation

aharren
Copy link
Contributor

@aharren aharren commented Nov 25, 2014

adapt lcl_configure to new location of build headers in CocoaPods 0.34.x and 0.35.x

adapt lcl_configure to new location of build headers in CocoaPods 0.34.x and 0.35.x
@aharren
Copy link
Contributor Author

aharren commented Nov 25, 2014

@orta @Keithbsmiley @alloy sending this via pod trunk push didn't work, because the Xcode project from the linting process doesn't compile (due to missing lcl_config* files), and there's no --quick for pod trunk push; therefore, I'm sending this as a pull request.

@aharren
Copy link
Contributor Author

aharren commented Nov 27, 2014

@orta @Keithbsmiley @alloy any thoughts on this?

@orta
Copy link
Member

orta commented Nov 27, 2014

FWIW doing it this way won't get added to web properties ( e.g. search, cocoadocs etc ) but would still work fine generally. Do you know if there's anything we can do to make it lint correctly? ( /cc @kylef )

@aharren
Copy link
Contributor Author

aharren commented Nov 27, 2014

A trunk lint --quick option would be cool, just like pod spec lint has.

Building an Xcode project requires some config files which don't exist in a plain project. So, I assume that all related specs couldn't be updated via trunk at the moment.

@aharren
Copy link
Contributor Author

aharren commented Nov 27, 2014

What also could help would be a possibility to add something locally to the Podfile which is created and used by pod trunk push. Then I could add the auto-configuration pod and a post-install hook which could create the config files.

@aharren
Copy link
Contributor Author

aharren commented Nov 30, 2014

@orta @kylef adding the following lines to the Podfile which is used by pod spec lint or pod trunk push could help and would create the required config files:

post_install do |installer|
  system 'Pods/LibComponentLogging-pods/configure/lcl_configure pod'
end

BTW is linting always using the folder /tmp/CocoaPods/Lint? What happens if pod spec lint is run in parallel on the same machine? (~> shouldn't the temp folder be a unique temp folder (like with mkdtemp)?)

@kylef
Copy link
Contributor

kylef commented Nov 30, 2014

@aharren You could make a CocoaPods plugin which add's this hook, as of version 0.36 you will need to explicitly define which plugins you want in your Podfile which means you'd have the same problem.

I'm wondering if we can add a --plugins option to pod {spec,lib} lint to allow using plugins which change how the linting works.

That, or we could allow you to create the Podfile manually and pass it to the linter. @kapin, what do you think?


You are right, currently it will fail if you try linting two things at once. I'd normally use pod spec lint <podspec1> <podspec2> ... to lint multiple specs at once. Please create an issue in CocoaPods to support this, or better yet. Perhaps a pull request changing this behaviour. I think the change would be mostly isolated to the single line over at https://github.com/CocoaPods/CocoaPods/blob/master/lib/cocoapods/validator.rb#L178-182.

@joshkalpin
Copy link
Member

@kylef I feel like that would be a massive change for the linter. I'm kind of concerned about the long-term effects of that too. I'm just getting into exam season, so I can't really look into it until the middle of December.

@kylef
Copy link
Contributor

kylef commented Dec 1, 2014

@kapin, fair enough.

In that case, let's merge this manually. @aharren, you will need to continue using pull-requests until we find a long-term solution for this problem.

kylef added a commit that referenced this pull request Dec 1, 2014
[Add] LibComponentLogging-pods 0.0.2
@kylef kylef merged commit cc6e022 into CocoaPods:master Dec 1, 2014
@aharren
Copy link
Contributor Author

aharren commented Dec 1, 2014

Thx.

You are right, currently it will fail if you try linting two things at once. I'd normally use pod spec lint ... to lint multiple specs at once. Please create an issue in CocoaPods to support this, or better yet. Perhaps a pull request changing this behaviour. I think the change would be mostly isolated to the single line over at https://github.com/CocoaPods/CocoaPods/blob/master/lib/cocoapods/validator.rb#L178-182.

@kylef I was thinking about a continuous integration environment where multiple pod calls may run in parallel (for different jobs). I'll have a look at the mentioned lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants