Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #pretty_print to PBXCopyFilesBuildPhase and PBXShellScriptBuildPhase #702

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Add #pretty_print to PBXCopyFilesBuildPhase and PBXShellScriptBuildPhase #702

merged 1 commit into from
Jul 23, 2019

Conversation

drcapulet
Copy link
Contributor

No description provided.

dnkoutso
dnkoutso reviewed Jul 23, 2019
View reviewed changes
lib/xcodeproj/project/object/build_phase.rb Outdated
@@ -204,6 +204,19 @@ class PBXCopyFilesBuildPhase < AbstractBuildPhase
#
attribute :dst_subfolder_spec, String, Constants::COPY_FILES_BUILD_PHASE_DESTINATIONS[:resources]

# @return [Hash{String => Hash}] A hash suitable to display the project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/the project/the build phase

dnkoutso
dnkoutso reviewed Jul 23, 2019
View reviewed changes
lib/xcodeproj/project/object/build_phase.rb Outdated
@@ -287,6 +300,22 @@ class PBXShellScriptBuildPhase < AbstractBuildPhase
# the build log.
#
attribute :show_env_vars_in_log, String

# @return [Hash{String => Hash}] A hash suitable to display the project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/the project/the build phase

@dnkoutso
Copy link
Contributor

Also maybe a CHANGELOG entry in enhancements

@dnkoutso dnkoutso merged commit 5b4e8ef into CocoaPods:master Jul 23, 2019
@drcapulet drcapulet deleted the alexc-pp branch July 23, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnkoutso dnkoutso dnkoutso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drcapulet @dnkoutso