Fix small bug where product references have a trailing dot #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command line tools are extension-less however the code for making the ref always put a dot for the extension no matter what. This small fix ensures the dot is only added if an extension is found, that way those tools don't have the extra dot that isn't actually part of the target's output name.
dnkoutso
approved these changes
May 4, 2020
|
Can you add a bug fix change log please? |
|
Thanks! |
|
@dnkoutso Added an entry. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a small bug with the
new_product_ref_for_targethelper where it didn't create the right path for command line tools because it always adds a.to the end, assuming an extension will be after it, but command line tools don't have extensions.I added a pair of new tests to ensure the change is properly handled for both targets with extensions and those without.