Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constants for Xcode 12.4 #806

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Conversation

esteluk
Copy link
Contributor

@esteluk esteluk commented Jan 27, 2021

I ran spec/fixtures/CommonBuildSettings/rebuild_from_xcode and there was
no change from Xcode 12.3.

CHANGELOG.md Outdated
@@ -8,7 +8,7 @@
[thiagohmcruz](https://github.com/thiagohmcruz)
[#401](https://github.com/CocoaPods/CocoaPods/issues/401)

* Bump Xcode version constants for Xcode 12.3
* Bump Xcode version constants for Xcode 12.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a separate entry instead of editing the existing one. Also please keep the two empty spaces at the end for markdown formatting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay 👍🏽 Fwiw this entry had already been changed from Xcode 12 -> 12.3

I ran `spec/fixtures/CommonBuildSettings/rebuild_from_xcode` and there was
no change from Xcode 12.3.
@dnkoutso dnkoutso merged commit 7efa821 into CocoaPods:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants