Add support for location scenario reference #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
freak4pc
force-pushed
the
location_scenario_reference
branch
2 times, most recently
from
3186da0
to
84d9323
Compare
|
Sorry for the ping but any chance to look at this? We want to add some testing to a different OSS project that needs this reference exposed. @dnkoutso 🙏 |
dnkoutso
reviewed
Mar 10, 2021
dnkoutso
approved these changes
Mar 10, 2021
freak4pc
force-pushed
the
location_scenario_reference
branch
from
84d9323
to
ccbb158
Compare
|
ready for you when you can :) @dnkoutso |
|
LGTM! |
dnkoutso
approved these changes
Mar 23, 2021
|
The approval isn't the issue (you already did that) I just don't have merging permissions unfortunately :) |
|
Thank you! Any plans on cutting a release soon? Seems like the last one was 6 months ago, based on GitHub at least? |
|
Also hoping to get a release soon as well! I would love to start using a few things that have been added since the last release. |
|
released with 1.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parses a launch action's location scenario reference - the portion which defines the simulated GPS location of a runnable scheme
I did my best to assume what are the right tests here, but I'm not a ruby developer so if I missed anything please do let me know :)
Thanks!