CSV support #5
Merged
CSV support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning to you @kapin |
| when :md | ||
| UI.puts "* [#{pod[:name]} - #{pod[:version]}](#{pod[:homepage]}) [#{pod[:license][:type]}] - #{pod[:summary]}" | ||
| when :csv | ||
| UI.puts "#{pod[:name]}, #{pod[:version]}, #{pod[:homepage]}, \"#{pod[:summary]}\", \"#{pod[:license][:type]}\"" |
There was a problem hiding this comment.
legit point, that was me trying to read it better, but it's not legit CSV
|
I'll take a proper look later tonight |
| @@ -15,14 +15,18 @@ class PodfileInfo < Command | |||
| def self.options | |||
| [ | |||
| ["--all", "Show information about all Pods with dependencies that are used in a project"], | |||
| ["--md", "Output information in Markdown format"] | |||
| ["--md", "Output information in Markdown format"], | |||
| ["--csv", "Output information in Markdown format"] | |||
There was a problem hiding this comment.
This should read in CSV format
|
Just the one comment otherwise LGTM and I'll update the gem when I get home |
|
Ping @orta |
|
oops, sorry sure :D |
|
Done |
|
I'll update the gem tonight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option for outputting as CSV.
Considering this does everything it is set out to do, I've moved it to
1.0.0too. No need for super low releases when it fits its scope correctly.