-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port to sinatra #126
port to sinatra #126
Conversation
script src="/javascripts/application.js" | ||
link href="/stylesheets/app.css" media="screen" rel="stylesheet" type="text/css" | ||
link rel="search" type="application/opensearchdescription+xml" href="http://cocoapods.org/opensearch" title="CocoaPods" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a 404, it has an extension of .xml?
get '/opensearch.xml' do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah, good point!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already fixed in a later commit👍
a href="#{subproject.issue_url}" = subproject.issue_url.split("github.com/")[-1].gsub("/issues/", "#") | ||
p = subproject.description | ||
hr | ||
/ ul#projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be related to the main purpose of this PR (Sinatra).
What's the intention here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was having nil issues, think its :key vs "key'
Migrates the pod_pages branch to pure sinatra