Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port to sinatra #126

Merged
merged 9 commits into from Mar 15, 2015
Merged

port to sinatra #126

merged 9 commits into from Mar 15, 2015

Conversation

orta
Copy link
Member

@orta orta commented Mar 15, 2015

Migrates the pod_pages branch to pure sinatra

script src="/javascripts/application.js"
link href="/stylesheets/app.css" media="screen" rel="stylesheet" type="text/css"
link rel="search" type="application/opensearchdescription+xml" href="http://cocoapods.org/opensearch" title="CocoaPods"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a 404, it has an extension of .xml?

get '/opensearch.xml' do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, good point!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already fixed in a later commit👍

a href="#{subproject.issue_url}" = subproject.issue_url.split("github.com/")[-1].gsub("/issues/", "#")
p = subproject.description
hr
/ ul#projects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be related to the main purpose of this PR (Sinatra).

What's the intention here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was having nil issues, think its :key vs "key'

orta added a commit that referenced this pull request Mar 15, 2015
@orta orta merged commit b1d5091 into pod_pages Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants