Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shared Rubocop file #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update shared Rubocop file #11

wants to merge 3 commits into from

Conversation

jasl
Copy link

@jasl jasl commented Jan 15, 2021

This updated Rubocop file designed for latest Rubocop (1.8 at time)

Notable change:

  • Performance linting rules extract to a standalone gem
  • Cops' namespace update
  • AllCops/Include is a whitelist in newer version, so must add lib/**/*.rb
  • Looks like ./ has problem, remove them, this should no harm

@jasl
Copy link
Author

jasl commented Jan 15, 2021

@segiddins
Please review.

@jasl jasl mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-makarov igor-makarov igor-makarov left review comments

@segiddins segiddins segiddins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasl @segiddins @igor-makarov