-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dokku deploy directly #16
Conversation
I made another base image layer with the python deps because building and installing all these python deps is still slow and annoying. Now that this works we can move towards it if we need to. |
rm -rf /aleph/.git && \ | ||
bower --allow-root --quiet install | ||
|
||
CMD newrelic-admin run-program gunicorn --workers 1 -b 0.0.0.0:5000 --worker-class gevent --timeout 600 --max-requests 3000 --max-requests-jitter 100 --log-file - --access-logfile - aleph.manage:app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be necessary to tell gunicorn what port or IP to bind to. This caused me problems last time, because dokku thought it bound to another port. I think we should let it use the defaults.
Here's the line from our old dokku:
CMD newrelic-admin run-program gunicorn --workers 1 --worker-class gevent --timeout 600 --max-requests 3000 --max-requests-jitter 100 --log-file - --access-logfile - aleph.manage:app
That explains a lot. I copied this before pulling your changes to If gunicorn will default to 5000 and listen on the right interface I'll On 12 October 2016 at 19:48, Greg Kempe notifications@github.com wrote:
|
dockerfile changes to support deploying directly from this aleph fork
hopefully temporary til we figure out how to customise upstream without forking