Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dokku deploy directly #16

Merged
merged 4 commits into from
Oct 12, 2016
Merged

Dokku deploy directly #16

merged 4 commits into from
Oct 12, 2016

Conversation

jbothma
Copy link

@jbothma jbothma commented Oct 12, 2016

dockerfile changes to support deploying directly from this aleph fork

hopefully temporary til we figure out how to customise upstream without forking

@jbothma jbothma merged commit 1752a5d into master Oct 12, 2016
@jbothma jbothma deleted the dokku-deploy-non-dockerfile branch October 12, 2016 10:39
@jbothma
Copy link
Author

jbothma commented Oct 12, 2016

I made another base image layer with the python deps because building and installing all these python deps is still slow and annoying. Now that this works we can move towards it if we need to.

rm -rf /aleph/.git && \
bower --allow-root --quiet install

CMD newrelic-admin run-program gunicorn --workers 1 -b 0.0.0.0:5000 --worker-class gevent --timeout 600 --max-requests 3000 --max-requests-jitter 100 --log-file - --access-logfile - aleph.manage:app

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be necessary to tell gunicorn what port or IP to bind to. This caused me problems last time, because dokku thought it bound to another port. I think we should let it use the defaults.

Here's the line from our old dokku:

CMD newrelic-admin run-program gunicorn --workers 1 --worker-class gevent --timeout 600 --max-requests 3000 --max-requests-jitter 100 --log-file - --access-logfile - aleph.manage:app

@jbothma
Copy link
Author

jbothma commented Oct 12, 2016

That explains a lot. I copied this before pulling your changes to
aleph-dokku. It used to be on 8000 because I just copied from something in
aleph and then fixed it with dokku proxy config but I couldn't find that
proxy config on dokku4. Finally it makes sense :)

If gunicorn will default to 5000 and listen on the right interface I'll
change to simplify the dockerfile. Kinda feel it works don't touch it :)

On 12 October 2016 at 19:48, Greg Kempe notifications@github.com wrote:

@longhotsummer commented on this pull request.

In Dockerfile
#16 (review):

COPY . /aleph
WORKDIR /aleph
ENV ALEPH_SETTINGS /aleph/contrib/docker_settings.py
-RUN pip install -q -e /aleph
-RUN rm -rf /aleph/.git && bower --allow-root --quiet install
+RUN pip install git+git://github.com/Code4SA/aleph_zagazettecrawler.git && \

  • pip install -q -e /aleph && \
  • rm -rf /aleph/.git && \
  • bower --allow-root --quiet install

+CMD newrelic-admin run-program gunicorn --workers 1 -b 0.0.0.0:5000 --worker-class gevent --timeout 600 --max-requests 3000 --max-requests-jitter 100 --log-file - --access-logfile - aleph.manage:app

It shouldn't be necessary to tell gunicorn what port or IP to bind to.
This caused me problems last time, because dokku thought it bound to
another port. I think we should let it use the defaults.

Here's the line from our old dokku:

CMD newrelic-admin run-program gunicorn --workers 1 --worker-class gevent
--timeout 600 --max-requests 3000 --max-requests-jitter 100 --log-file -
--access-logfile - aleph.manage:app


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#16 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAOZGXc_NzIzDC0yYgYAHLHwdnc4vYUfks5qzR1sgaJpZM4KUnHg
.

jbothma pushed a commit that referenced this pull request Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants