Add TermTransition and replace EpochTransition #1519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2019
|
Any reason for keeping the |
`is_epoch_begin` flag which is determined by the result of `epoch_tranistion` call doesn't make any differences whether it is true or false since `on_new_block`, `on_epoch_begin` does nothing on it. So it is safe to remove and to replace with `is_term_begin` which also does nothing for now for the further implementation. Inserted `EpochTransition` is not read anymore and inserting it does not change state root. So removing it doesn't introduce breaking change unless reusing the key index.
`EpochTransition` is not used anymore after being replaced by `TermTransition`
foriequal0
force-pushed
the
feature/term-change
branch
from
f758595
to
81d7d0c
Compare
|
@foriequal0 Please resolve the conflict |
|
'TermId' should be changed to a sequential number instead of block number. I'll fix it and update this PR. |
foriequal0
changed the title
2 tasks
foriequal0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should compatible with the older version of node, or data.
Removing EpochTransition leave garbage on DB for existing DB.
TermTransition does nothing for now.
Merge after: #1508