Swift Package + WorkspaceClient module #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoCarnevali
force-pushed
the
modules-and-client
branch
2 times, most recently
from
c9171ea to
58e2239
Compare
MarcoCarnevali
changed the title
|
Please resolve conflicts. |
MarcoCarnevali
force-pushed
the
modules-and-client
branch
from
58e2239 to
7d343d7
Compare
@austincondiff should be done now! |
xinix909
pushed a commit
to xinix909/CodeTransfer
that referenced
this pull request
Sep 7, 2024
[feat]: Added Bash language support
xinix909
pushed a commit
to xinix909/CodeTransfer
that referenced
this pull request
Sep 7, 2024
…ditApp#14) * Separate Cursor Updates, Fix Focus Issues * Linter * Update TextSelectionManagerTests.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR would introduce a modularization to CodeEdit. I've created a local Swift Package (inside the
CodeEditModulesfolder) which would contain all our module targets. As an example I've built aWorkspaceClientwhich is mockable client that gives the ability to retrieve the list of files in a given directory. This target has a testTarget too.Architecturing the app in this way it would help us building the app in a more dynamic and easy way. Each target can be built independently.
Building clients in a composable way would give us the ability to mock each module easily.
For example a simple mock I've created is the
.emptyone, let's say we want to test an empty workspace we can simply replace the.defaultinitialization on our main app with the empty one!Note: The logic for retrieving the list of files is a re-implementation of the already-built
Workspace, I haven't changed the actual logic. The test introduced is just a simple test we might/should add more tests.