Refactored how themes are stored and loaded #1601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austincondiff
requested review from
a team,
matthijseikelenboom,
thecoolwinter,
Wouter01,
LeoBorai and
tom-ludwig
…sers themes folder. Corrected some theme colors to sRGB color space.
austincondiff
force-pushed
the
theme-folder-rename
branch
from
01c5235 to
9484c89
Compare
Wouter01
previously approved these changes
Mar 5, 2024
tom-ludwig
requested changes
Mar 5, 2024
CodeEdit/Features/Settings/Pages/ThemeSettings/Models/ThemeModel.swift
Outdated
Show resolved
Hide resolved
austincondiff
commented
Mar 7, 2024
CodeEdit/Features/Settings/Pages/ThemeSettings/Models/ThemeModel.swift
Outdated
Show resolved
Hide resolved
tom-ludwig
approved these changes
Mar 7, 2024
thecoolwinter
approved these changes
Mar 9, 2024
|
Looks good, I like these changes it seems like a good idea to differentiate between default and user defined themes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we are copying bundled themes to ~/Application Support/CodeEdit/themes, then loading them from there. This means that if we ever want to change themes or add new bundled themes, the user would need to delete that themes folder for any changes to be picked up. We were also hardcoding each bundled theme in the code.
Now, Default themes are bundled with CodeEdit.
We removed all hardcoded theme names and we simply scan the contents of the DefaultThemes folder.
Themes added to ~/Application Support/CodeEdit/Themes are now considered user-defined or custom themes. Themes the user installs will later be placed here.
Converted all themes hex values to now use the sRGB color space.
Themes now use the new
.cethemesfile extension but still in json format.Warning
Theme editing via the UI is now broken and will be fixed in a future PR. This is because we will need to copy bundled themes into the user Themes folder to make edits to bundled themes. I recommend that we merge anyways and do this additional work as part of a future release as we are still in pre-alpha.