Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Up Code #1737

Merged
merged 20 commits into from
Jun 22, 2024
Merged

Clean Up Code #1737

merged 20 commits into from
Jun 22, 2024

Conversation

FastestMolasses
Copy link
Member

@FastestMolasses FastestMolasses commented May 25, 2024 •
edited by austincondiff
Loading

Description

This PR will contain some general code clean up, naming fixes, documentation and warning fixes.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

@FastestMolasses FastestMolasses added WIP This is work-in-progress other chore labels May 25, 2024
@FastestMolasses FastestMolasses added this to the v0.2.0 milestone May 25, 2024
@thecoolwinter thecoolwinter changed the title Cleaning up code Clean Up Code Jun 18, 2024
@thecoolwinter thecoolwinter marked this pull request as ready for review June 18, 2024 00:32
@thecoolwinter thecoolwinter removed WIP This is work-in-progress other labels Jun 18, 2024
thecoolwinter
thecoolwinter previously approved these changes Jun 18, 2024
View reviewed changes
@thecoolwinter thecoolwinter mentioned this pull request Jun 18, 2024
Closed
thecoolwinter
thecoolwinter previously approved these changes Jun 21, 2024
View reviewed changes
@austincondiff austincondiff merged commit c6a8f8c into main Jun 22, 2024
2 checks passed
@austincondiff austincondiff deleted the cleanup branch June 22, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

@austincondiff austincondiff austincondiff approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@bombardier200 bombardier200 Awaiting requested review from bombardier200

@Wouter01 Wouter01 Awaiting requested review from Wouter01

@tom-ludwig tom-ludwig Awaiting requested review from tom-ludwig

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

🐞 Xcode says OpenWithCodeEdit app extension's version number should tally with that of CodeEdit app
4 participants
@FastestMolasses @austincondiff @thecoolwinter @matthijseikelenboom