Index data to AWS elastic search from AWS cloud search #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 14, 2017 16:13
Fix tests to run with elastic search Refactor tests to remove redundant tests
Add tests for the health facilities scraper
Gathondu
force-pushed
the
feature-elastic-search
branch
from
59c8cf4
to
993c7c4
Compare
Gathondu
force-pushed
the
feature-elastic-search
branch
from
993c7c4
to
4e703be
Compare
|
Hey @Gathondu. Thanks for the PR. Could you also add the documentation to the README? |
DavidLemayian
suggested changes
Jun 20, 2017
| @@ -17,8 +17,13 @@ | |||
| # Clinical document endpoint | |||
| "cloudsearch_cos_endpoint": "http://doc-cfa-healthtools-ke-cos-nhxtw3w5goufkzram4er7sciz4.eu-west-1.cloudsearch.amazonaws.com/", | |||
| # Health facilities endpoint | |||
| "cloudsearch_health_faciities_endpoint":"https://doc-health-facilities-ke-65ftd7ksxazyatw5fiv5uyaiqi.eu-west-1.cloudsearch.amazonaws.com", | |||
| "cloudsearch_health_faciities_endpoint": "https://doc-health-facilities-ke-65ftd7ksxazyatw5fiv5uyaiqi.eu-west-1.cloudsearch.amazonaws.com", | |||
There was a problem hiding this comment.
Let's remove all the cloudsearch endpoints.
There was a problem hiding this comment.
@DavidLemayian this too is handled in the other branch
| # Bucket="cfa-healthtools-ke", | ||
| # Key=self.health_facilities_scraper.s3_key | ||
| # )['Body'].read() | ||
| # self.assertEqual(uploaded_data, data) |
There was a problem hiding this comment.
I tried writing tests for health facilities and test that they are uploading but it was failing because of the key. Funny enough I removed it too in the other branch
There was a problem hiding this comment.
@DavidLemayian funny. I did this on the other branch..I merged to develop on my local repo and continued with the slack integration. This was handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Shifts the indexing of the scraped data from AWS cloud search to elastic search.
Fixes the health-facilities scrapper
Adds tests for health facilities
Refactors tests that were already there
Add continuous integration with CircleCi
Description of Task to be completed?
Replace CloudSearch with ElasticSearch
How should this be manually tested?
Run nostests --nocapture in a terminal pointing to the projects directory and virtual environment