Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing Build #788

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Fix Failing Build #788

merged 4 commits into from
Jul 18, 2024

Conversation

kelvinkipruto
Copy link
Contributor

Description

This PR fixes failing build introduced by #785. It also add climatemappedafrica to the docker-compose file

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@kelvinkipruto
Copy link
Contributor Author

kelvinkipruto commented Jul 18, 2024

@CodeForAfrica/tech I have a bug I'm trying to fix with this PR introduced by #785.
Building ClimateMappedAfrica fails with the following error:

Failed to compile.

../../packages/commons-ui-next/src/Link/Link.js
Module not found: Can't resolve '@/commons-ui/next/utils/isExternalUrl'

After some investigation, I have determined that the issue is caused by using Link from the commons-ui/next package inside hurumap/next.
Pesayetu uses the same package and builds successfully though.

Copy link
Contributor

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-788 Visit

@kelvinkipruto kelvinkipruto marked this pull request as ready for review July 18, 2024 10:22
Copy link
Contributor

@m453h m453h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Dockerfile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
Signed-off-by: Kipruto <43873157+kelvinkipruto@users.noreply.github.com>
@kelvinkipruto kelvinkipruto added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 058afe0 Jul 18, 2024
6 checks passed
@kelvinkipruto kelvinkipruto deleted the fix/fix-failing-build branch July 18, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants