-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@/engineeringblog App Navbar #865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I noticed that the changes in tsconfig.json
have "strict": false
, unless I'm missing something, since we are going with TS, wouldn't it be a good idea to have strict type checking early on ?
Not sure why I even touch that 🤦🏽 ... will fix. |
Description
This PR add initial implementation of Navbar and app level metadata:
NOTE:: A lot of our components and functions appear to be client only i.e. use useEffect hooks, etc. We'll need to review them to really take advantage of the app directory/React 18 separatation of server vs client components.
Fixes #844
Type of change
Screenshots
Mobile
Desktop
Checklist: