Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@/engineeringblog App Navbar #865

Merged
merged 9 commits into from
Sep 2, 2024
Merged

@/engineeringblog App Navbar #865

merged 9 commits into from
Sep 2, 2024

Conversation

kilemensi
Copy link
Member

@kilemensi kilemensi commented Aug 30, 2024

Description

This PR add initial implementation of Navbar and app level metadata:

  • favicons/robots.txt, etc.
  • switch to user system fonts rather than force to download one... most systems are moving towards this including GitHub, StackOverflow, etc.

NOTE:: A lot of our components and functions appear to be client only i.e. use useEffect hooks, etc. We'll need to review them to really take advantage of the app directory/React 18 separatation of server vs client components.

Fixes #844

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

Mobile

Screenshot 2024-08-30 at 13 42 19

Desktop

Screenshot 2024-08-30 at 13 42 01

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kilemensi kilemensi added the enhancement New feature or request label Aug 30, 2024
@kilemensi kilemensi self-assigned this Aug 30, 2024
@kilemensi kilemensi requested a review from a team August 30, 2024 11:59
Copy link
Contributor

@kelvinkipruto kelvinkipruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@m453h m453h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I noticed that the changes in tsconfig.json have "strict": false, unless I'm missing something, since we are going with TS, wouldn't it be a good idea to have strict type checking early on ?

@kilemensi
Copy link
Member Author

Looks good, I noticed that the changes in tsconfig.json have "strict": false, unless...

Not sure why I even touch that 🤦🏽 ... will fix.

@kilemensi kilemensi added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit 13b879a Sep 2, 2024
4 checks passed
@kilemensi kilemensi deleted the feat/blog_app_navbar branch September 2, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

@engineeringblog - switch to commons-ui Navbar
3 participants