Add SSRF detector #643
Merged
Add SSRF detector #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bertschneider
force-pushed
the
FUZZ-483_ssrf_bug_detector
branch
from
b102ebf
to
806c69a
Compare
bertschneider
force-pushed
the
FUZZ-483_ssrf_bug_detector
branch
8 times, most recently
from
e5ebda2
to
b7ac3a1
Compare
There was a problem hiding this comment.
Looks reasonable to me. The example fuzzer is quite slow, and I was able to get one slow output (as mentioned in the sanitizer comments), which I'm not sure is a good finding here..
Slowest unit: 75 s:
artifact_prefix='/private/var/tmp/_bazel_christopher/8c60c24fbbc15a396e9df7c56a2aae10/execroot/jazzer/bazel-out/darwin_arm64-opt/testlogs/examples/BatikTranscoderFuzzer/test.outputs/'; Test unit written to /private/var/tmp/_bazel_christopher/8c60c24fbbc15a396e9df7c56a2aae10/execroot/jazzer/bazel-out/darwin_arm64-opt/testlogs/examples/BatikTranscoderFuzzer/test.outputs/slow-unit-17f8ba6eb1d560a71023696c46f7d388e9d7405e
Base64: ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODg4ODHzMQ==
sanitizers/src/main/java/com/code_intelligence/jazzer/sanitizers/SsrfInjection.kt
Outdated
Show resolved
Hide resolved
sanitizers/src/main/java/com/code_intelligence/jazzer/sanitizers/SsrfInjection.kt
Outdated
Show resolved
Hide resolved
bertschneider
force-pushed
the
FUZZ-483_ssrf_bug_detector
branch
from
b7ac3a1
to
3fbf5eb
Compare
0xricksanchez
approved these changes
Mar 7, 2023
bertschneider
force-pushed
the
FUZZ-483_ssrf_bug_detector
branch
3 times, most recently
from
0878ff6
to
2f1fadd
Compare
fmeum
force-pushed
the
FUZZ-483_ssrf_bug_detector
branch
3 times, most recently
from
e350324
to
a9547c5
Compare
Server Side Request Forgery (SSRF) attacks occur when requests to destinations based on untrusted data are executed. This could lead to exfiltration of sensitive data or exposure of internal services. The sanitizer detects such attacks by checking if the fuzzer was able to inject a honeypot host name into the requested destination. If this is the case, it reports a high severity security issue. Checks are implemented via `java.net.Socket.connect` and `java.nio.channels.SocketChannel.connect` methods.
fmeum
force-pushed
the
FUZZ-483_ssrf_bug_detector
branch
from
a9547c5
to
5bbf62a
Compare
fmeum
force-pushed
the
FUZZ-483_ssrf_bug_detector
branch
from
5bbf62a
to
6efc834
Compare
|
@bertschneider I updated the PR, could you take a look? I am thinking that we should maybe reduce the severity to Medium. What do you think? |
bertschneider
commented
Apr 27, 2023
|
I really like this approach, especially the configuration via scopes. |
|
@bertschneider Do you have an idea why the HTTPClient test isn't skipped in CI? Am I using the tag incorrectly? |
bertschneider
force-pushed
the
FUZZ-483_ssrf_bug_detector
branch
from
44df9ec
to
bbef9e9
Compare
bertschneider
force-pushed
the
FUZZ-483_ssrf_bug_detector
branch
from
bbef9e9
to
359a2e5
Compare
fmeum
force-pushed
the
FUZZ-483_ssrf_bug_detector
branch
from
359a2e5
to
0cfc340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server Side Request Forgery (SSRF) attacks occur when requests to destinations based on untrusted data are executed. This could lead to exfiltration of sensitive data or exposure of internal services.
The sanitizer detects such attacks by checking if the fuzzer was able to inject a honeypot host name into the requested destination. If this is the case, it reports a high severity security issue.
Checks are implemented via
java.net.Socket.connectandjava.nio.channels.SocketChannel.connectmethods.