-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
junit: Fix CLI runs on individual files #819
Conversation
89b7666
to
c656ec3
Compare
c656ec3
to
6063916
Compare
|
|
16625cb
to
4f90ebe
Compare
|
4f90ebe
to
bebc967
Compare
@br-lewis @bertschneider The finding is an NPE in |
|
bebc967
to
ec50431
Compare
This is ready for review again, I fixed the Windows CI issue. |
|
Disable git's automatic LF/CRLF conversion. We aim to support Windows builds from source as is and seed files can be sensitive to line endings.
When all user-provided libFuzzer path arguments are files, the JUnit executor now correctly starts libFuzzer in reproduction mode by not adding any directories to the command line. In particular, this fixes a crash when Jazzer is invoked on a single file to reproduce a particular finding.
ec50431
to
b20c6c2
Compare
|
@fmeum Yes, you're right! Only the bazel tests used the experimental mutator. Due to the previous CI Sense integration problems we didn't notice the missing flag in The experimental mutator can be enabled by adding the following snippet to
Do you want to enable the experimental mutator in this PR or should I create a new one? |
Will do, thanks for the pointer! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
When all user-provided libFuzzer path arguments are files, the JUnit
executor now correctly starts libFuzzer in reproduction mode by not
adding any directories to the command line. In particular, this fixes
a crash when Jazzer is invoked on a single file to reproduce a
particular finding.